Conversation
Strip filler advice from docs/coding-guidelines.md and rewrite as docs/python-coding-guidelines.md — grounded in actual databao-cli patterns with code examples. Filename scoped to Python so future TypeScript guidelines slot in cleanly. Update all references. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Replaces the repo’s generic coding guidelines document with a Python-specific guidelines doc for databao-cli, and updates all internal references and validation hooks to point at the new filename.
Changes:
- Added
docs/python-coding-guidelines.mdand removeddocs/coding-guidelines.md. - Updated references in agent guidance docs and repo metadata files to the new doc path.
- Updated smoke-test and pre-commit file filters to validate the new guidelines doc.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/smoke-test-skills.sh | Updates smoke check to assert the new guidelines doc exists. |
| docs/python-coding-guidelines.md | Introduces new Python-specific project coding guidelines and examples. |
| docs/coding-guidelines.md | Deletes the old generic coding guidelines doc. |
| CLAUDE.md | Updates reference link to point at the new guidelines doc. |
| .pre-commit-config.yaml | Updates validate-agent-guidance hook file regex to include the new doc name. |
| .claude/skills/review-architecture/SKILL.md | Updates the “review order” list to reference the new guidelines doc. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…ei.gasparian/DBA-282-python-coding-guidelines
…ests Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
SimonKaran13
approved these changes
Mar 20, 2026
SimonKaran13
approved these changes
Mar 20, 2026
gasparian
commented
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace the generic
docs/coding-guidelines.mdwithdocs/python-coding-guidelines.md— project-specific Python patterns with code examples, stripped of filler. Filename scoped to Python for future TypeScript guidelines.Changes
New Python coding guidelines
Files
docs/python-coding-guidelines.md(new)docs/coding-guidelines.md(deleted)Reference updates
Files
CLAUDE.md.pre-commit-config.yamlscripts/smoke-test-skills.sh.claude/skills/review-architecture/SKILL.mdTest Plan
make checkpasses (ruff + mypy + validate-agent-guidance)make testpasses (65/65)make lint-skillspassesmake smoke-skills— all review-architecture doc checks pass🤖 Generated with Claude Code